Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: ModuleBase.cs - Same Module Message Wont Appear After It Is Dismissed. #3599

Closed
thabaum opened this issue Dec 29, 2023 · 0 comments · Fixed by #3600
Closed

Issue: ModuleBase.cs - Same Module Message Wont Appear After It Is Dismissed. #3599

thabaum opened this issue Dec 29, 2023 · 0 comments · Fixed by #3600

Comments

@thabaum
Copy link
Contributor

thabaum commented Dec 29, 2023

I have been experiencing behaviors throughout the admin UI that stops user notifications of messages in modules if you dismiss one using the X close link.

I have a fix that resolves this behavior resulting in new messages appearing after closing that maybe an acceptable solution.

Issue similar to behaviors described in #3597, however that issue sounds like it wont get "cleared", maybe this is what behavior was trying to be described. They can provide more details on that issue if this upcoming PR does not fix it for them.

I am using the ClearModuleMesssage() method to do the trick in cases where the message should be cleared and is not for future reference.

I will be submitting a PR shortly that will resolve this behavior in the ModuleBase.cs logic relating.

@thabaum thabaum changed the title Behavior Issue: ModuleBase.cs - Same Module Message Wont Appear After It Is Dismissed. Issue: ModuleBase.cs - Same Module Message Wont Appear After It Is Dismissed. Dec 30, 2023
sbwalker added a commit that referenced this issue Jan 2, 2024
Clear Module Message Prior To Adding A Message To UI. Fixes #3599
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant