Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize Logs Messages #933

Closed
hishamco opened this issue Nov 19, 2020 · 3 comments · Fixed by #954
Closed

Localize Logs Messages #933

hishamco opened this issue Nov 19, 2020 · 3 comments · Fixed by #954

Comments

@hishamco
Copy link
Contributor

We should localize the static logs, coz the dynamics logs are tricky but we could may find a good solution to localize them

@sbwalker
Copy link
Member

You are talking about localizing the static portions of the log messages, correct? For example:

        await Log(_alias, LogLevel.Error, string.Empty, ex, "Error Loading Site {SiteId} {Error}", _alias.SiteId, ex.Message);

You want to localize the ""Error Loading Site" static text and allow the dynamic parameters for {SiteId} and {Error} to be populated by the environment without any explicit localization.

I agree.

@hishamco
Copy link
Contributor Author

Exactly!!

@hishamco
Copy link
Contributor Author

I did some progress here, I come up with idea to reduce the RESX files into 1 which is cool and easy to manage, during my testing I notice the dynamic parameters {Param} are sometimes a JSON object like what I saw when creating a new role. I'm not sure if it's necessary to do that, IMHO we could use role name in this case and keep the JSON object on the properties as its for detail info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants