Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize log messages #954

Merged
merged 3 commits into from
Nov 30, 2020
Merged

Localize log messages #954

merged 3 commits into from
Nov 30, 2020

Conversation

hishamco
Copy link
Contributor

Fixes #933

@hishamco
Copy link
Contributor Author

Log

This is how the added role appear in Arabic

@hishamco
Copy link
Contributor Author

I added Resources folder so anyone after can add the resources without creating that folder

@sbwalker
Copy link
Member

Can you please explain why you needed to add the Root Namespace? It seems unrelated to this Logging enhancement. And it did not seem to be necessary for the foundational localization enhancements you add in 2.0.0.

@hishamco
Copy link
Contributor Author

why you needed to add the Root Namespace

This because you change the rootnamesapce in Oqtane.Server.csproj

<RootNamespace>Oqtane</RootNamespace>

@hishamco
Copy link
Contributor Author

I already add it to Oqtane.Client but seems I miss it for Oqtane.Server, if you remember that is why I asked to change the Module Creator too to avoid adding this attribute

@sbwalker sbwalker merged commit e57f067 into oqtane:dev Nov 30, 2020
@hishamco hishamco deleted the localize-logs branch November 30, 2020 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Localize Logs Messages
2 participants