Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance improvement - set IsFixed="true" on ModuleState CascadingValues so that Blazor will not monitor them for changes #1090

Merged
merged 1 commit into from
Feb 5, 2021
Merged

Performance improvement - set IsFixed="true" on ModuleState CascadingValues so that Blazor will not monitor them for changes #1090

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Oqtane.Client/Modules/Controls/TabStrip.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
@namespace Oqtane.Modules.Controls
@inherits ModuleControlBase

<CascadingValue Value="this">
<CascadingValue Value="this" IsFixed="true">
<div class="container-fluid">
<div class="form-group">
<ul class="nav nav-tabs" role="tablist">
Expand Down
2 changes: 1 addition & 1 deletion Oqtane.Client/UI/ContainerBuilder.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
@namespace Oqtane.UI

<CascadingValue Value="@_moduleState">
<CascadingValue Value="@_moduleState" IsFixed="true">
@DynamicComponent
</CascadingValue>

Expand Down
2 changes: 1 addition & 1 deletion Oqtane.Client/UI/ModuleInstance.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
@inject IStringLocalizer<ModuleInstance> Localizer

<ModuleMessage Message="@_message" Type="@_messagetype" />
<CascadingValue Value="this">
<CascadingValue Value="this" IsFixed="true">
@DynamicComponent
</CascadingValue>
@if (_progressindicator)
Expand Down