Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the localization manager resolution #1095

Merged
merged 1 commit into from
Feb 6, 2021

Conversation

hishamco
Copy link
Contributor

@hishamco hishamco commented Feb 6, 2021

Addresses #1094

@hishamco
Copy link
Contributor Author

hishamco commented Feb 6, 2021

@sbwalker please merge this ASAP, it's a blocker

@sbwalker sbwalker merged commit 0089345 into oqtane:dev Feb 6, 2021
@isolution1
Copy link

The new error is still related to localization
InvalidOperationException: Sequence contains no elements
System.Linq.ThrowHelper.ThrowNoElementsException()
System.Linq.Enumerable.First(IEnumerable source)
Oqtane.Pages.HostModel.OnGet() in _Host.cshtml.cs
+
var defaultLanguage = languages.Where(l => l.IsDefault).SingleOrDefault() ?? languages.First();

@sbwalker
Copy link
Member

sbwalker commented Feb 7, 2021

These issues all seem to be related to the refactoring in #1071. @hishamco I would suggest you clear the connection string in your local installation and do a clean install to test your changes.

@hishamco
Copy link
Contributor Author

hishamco commented Feb 8, 2021

Hope to do a final test on a clean installation

@sbwalker
Copy link
Member

sbwalker commented Feb 8, 2021

I just fixed the issue in #1096

@hishamco hishamco deleted the localization-manager branch February 8, 2021 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants