Fixed targeting .NET 7.0 in ThemeController and ModuleDefinitionContr… #2895
Conversation
|
The namespace for theme doesnt conform to the standard
should we make it [Owner].Themes.[Theme]? |
|
I don't believe the framework should have used ".Themes" - it should have used ".Theme" but it's too much work to change the names of default themes at this point due to upgrade challenges. Including ".Theme" in the wwwroot is redundant currently as it's already within a Themes parent folder. However one item on the future roadmap is to transition to using the more standard .NET _content folder approach for static assets which would mean it would be useful to include the identifier in the folder name. And it would be useful for assembly names as well so that you can easily be able to differentiate themes from modules in the /bin. So I would be in favor of using [Owner].Theme.[Theme] as a naming convention. |
|
Should I make that change to the template and submit a commit to this pull request ? |
|
Just submit a new PR for the change |
…oller missed in #2888 and #2890