Added ThemeSettings and ContainerSettings to Default Theme Template #2940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added ThemeSettings and ContainerSettings to Default Theme Template to Demonstrate how these features could be added to developers designing a theme as requested and discussed in Issue oqtane#2633
|
@vnetonline these changes look valid however my feedback is that the templates are not intended to replicate the features of the default templates - they are intended to provide a simple demonstration of how to use various Oqtane features. On that note, if we are going to add Theme Settings and Container Settings to the theme template, I would suggest that we only include a few setting options. For Theme Settings: Show Login and Show Register, and for Container Settings: Display Title. The other options should be removed. It also appears that the solution file was accidentally removed in this PR (3b0ffde) - so I am glad to see this adds it back. |
Added ThemeSettings and ContainerSettings to Default Theme Template Added ThemeSettings and ContainerSettings to Default Theme Template to Demonstrate how these features could be added to developers designing a theme as requested and discussed in Issue oqtane#2633 Includeda few setting options as per suggestion by @sbwalker intended to provide a simple demonstration of how to use Theme and Container settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ThemeSettings and ContainerSettings to Default Theme Template to Demonstrate how these features could be added to developers designing a theme as requested and discussed in Issue #2633