Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4028: check whether the user info is null. #4029

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

zyhfish
Copy link
Contributor

@zyhfish zyhfish commented Mar 20, 2024

No description provided.

@sbwalker
Copy link
Member

@zyhfish this code change is not valid:

 if (PageState.Runtime == Shared.Runtime.Hybrid && PageState.User != null)

It changes the meaning of the condition - instead of having logic dedicated to the Hybrid scenario, it will now execute the non-Hybrid logic if the User is null. If we want to include a null check then it needs to be within the Hybrid logic:

 if (PageState.Runtime == Shared.Runtime.Hybrid)
 {
    if (PageState.User != null)
    {

@zyhfish
Copy link
Contributor Author

zyhfish commented Mar 21, 2024

Hi @sbwalker , thx so much for the review, code is updated.

@sbwalker sbwalker merged commit 1cdedb8 into oqtane:dev Mar 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants