Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Theme Template to Bootstrap 5.3.3 #4487

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

leigh-pointer
Copy link
Contributor

No description provided.

@thabaum
Copy link
Contributor

thabaum commented Aug 7, 2024

oops sorry i see you did this one already I was looking for an issue with wrong cdn being used on a page in the cyborg theme I will close this but looks like this fixes

I see your fix adds cyborg theme to default?

I noticed the sha was different from my pull request...

Issue I was trying to fix when I did this one up not seeing yours...

https://cdnjs.cloudflare.com/ajax/libs/bootswatch/5.3.3/cyborg/dist/cyborg/bootstrap.css

being called in the default Oqtane theme of an install upgraded... although the theme loads ok and I dont see anything trying to load this naturally, I get this error in console I was trying to locate to resolve but have not yet:

image

@thabaum
Copy link
Contributor

thabaum commented Aug 7, 2024

notice the "dist/cyborg" added to the string makes it fail... on the OqtaneTheme that actually does use the bootstrap Cyborg theme

I dont see it all the time, and cant reproduce except once earlier so I am not reporting it...

@thabaum
Copy link
Contributor

thabaum commented Aug 7, 2024

@leigh-pointer unless we are changing the template theme to cyborg you can copy my PR update for the CSS hash to simply update the theme bootstrap on this PR and I can close mine...

@thabaum
Copy link
Contributor

thabaum commented Aug 7, 2024

@leigh-pointer thanks for making the updates as discussed I will now close #4490 as this PR will now fix #4489

@sbwalker sbwalker merged commit aa19b81 into oqtane:dev Aug 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants