Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Dynamic TargetFramework in Debug Scripts #4897 #4898

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

leigh-pointer
Copy link
Contributor

Description

This PR updates our debug scripts (both .cmd and .sh) to dynamically use the current TargetFramework passed from the build process. This change improves flexibility and future-proofs our build process for different .NET versions.

Changes Made

  • Modified build events to pass $(TargetFramework) to debug scripts
  • Updated debug.cmd to accept and use the TargetFramework parameter
  • Updated debug.sh to accept and use the TargetFramework parameter
  • Replaced hardcoded framework versions (e.g., net9.0) with the dynamic TargetFramework variable in file paths

How to Test

  1. Build the project with different TargetFramework settings
  2. Verify that the correct files are copied to the appropriate directories based on the current TargetFramework

Impact

This change affects the build process but should not impact runtime behavior. It will make it easier to manage different .NET versions in the future.

This PR updates our debug scripts (both .cmd and .sh) to dynamically use the current TargetFramework passed from the build process. This change improves flexibility and future-proofs our build process for different .NET versions.
Add the $TargetFramework macro to the Release Builds
@sbwalker sbwalker merged commit 15bc47e into oqtane:dev Dec 9, 2024
1 check passed
@leigh-pointer leigh-pointer deleted the TemplateParam branch December 10, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants