Fix - return to url during login fail when returnurl contains "/"

[PavelVsl]

Url was transformed to
https://xxxx.yyy/login/!/returnurl=test/Detail
instead of
https://xxxx.yyy/login?returnurl=test/Detail

[sbwalker]

I am not sure if this is the correct fix as hardcoding the parameter name of "returnurl=" in the logic seems far too specific. After looking at the ParseParameters() method it appears that if you want a parameter value to be properly interpreted as a querystring then you should prefix the value with a "?". If you do not include the "?" it will try to interpret it as a url parameter - and in this case because the value contains a "/" path delimiter it will be confused. I believe the proper way to fix this is in LoginBase:

NavigationManager.NavigateTo(NavigateUrl("login", "?returnurl=" + returnurl));

[PavelVsl]

Yes, URL encoding /decoding will be correct way, but I'ts more complicated and I'm not sure where should be decoding/encoding implemented.

[sbwalker]

See my edited comment above... I don't think url encoding is necessary after reviewing the code.

[PavelVsl]

ok. I will do it your way. Updated version.

[sbwalker]

Thank you @chlupac. We really need some better developer documentation to explain the usage for some framework APIs. @PoisnFang did a great job on the Url Parameter enhancement, but clearly there are a few edge cases which can cause challenges.

[PizzaConsole]

Yes I see what is happening here... not something I had thoughy about during dev

[sbwalker]

@PoisnFang I dont think there is anything wrong with your solution - there are 2 fairly trivial options to handle this - either prefix the parameters with "?" or url encode the values so that they do not contain "/"