Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: unify OpenAPI responses from 'details' or 'message' to 'message' #70

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

shgokita
Copy link
Contributor

📃 Ticket

https://github.com/FujitsuResearch/QuantumCloudPlatform/issues/283

✍ Description

  • refactor OpenAPI specifications and error response schemas in errors.py
  • I think it is better to use the schema generated from datamodel-code-generator, but it does not seem to support status codes, so I use the response model of errors.py written in the manual.

📸 Test Result

see CI result

🔗 Related PRs

@shgokita shgokita added chore Minor changes or maintenance tasks refactor Code changes that neither fix a bug nor add a feature labels Jan 21, 2025
@shgokita shgokita requested a review from orangekame3 as a code owner January 21, 2025 06:18
@github-actions github-actions bot added the test Adding or correcting existing tests label Jan 21, 2025
Copy link
Collaborator

@orangekame3 orangekame3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM

@orangekame3 orangekame3 merged commit 1240bd1 into develop Jan 21, 2025
7 of 8 checks passed
@orangekame3 orangekame3 deleted the issue#283 branch January 21, 2025 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Minor changes or maintenance tasks refactor Code changes that neither fix a bug nor add a feature test Adding or correcting existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants