Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Truncate parsed version to X.Y.Z #26

Merged
merged 1 commit into from
May 3, 2022
Merged

Truncate parsed version to X.Y.Z #26

merged 1 commit into from
May 3, 2022

Conversation

sormuras
Copy link
Member

@sormuras sormuras commented May 3, 2022

Fixes #25

delabassee
delabassee approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@delabassee delabassee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sormuras sormuras merged commit 17d84c7 into main May 3, 2022
@sormuras sormuras deleted the issues/25/truncate-version-to-xyz branch May 3, 2022 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delabassee delabassee delabassee approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using GA, got - Error: The string '18.0.1.1' is not valid SemVer notation for a Java version.
2 participants
@sormuras @delabassee