Skip to content

Conversation

TheInMemoryGuy
Copy link
Contributor

WMS ID: 11255

General requirements

  1. Information in the workshop is adequate and updated
  2. Code is correct and working
  3. Links are correct
  4. Make sure you enter the help email link in your manifest.json
  5. Please make sure WMS URLs are updated as needed after your PR is approved

Checklist - Refer to the QA document for the complete list

Please confirm that the following is completed before submitting your PR

AndyRivenes and others added 16 commits August 29, 2022 14:39
New In-Memory 21c Lab
Removed image files and update md files with text to replace images.
Updated manifest.json files for new labs. Only Desktop was up to date.
Update README.md for new lab description
Fixed setup.md with correct row number for Lineorder table.
Added the proper text for moving to the next lab at the end of each lab's markdown file.
Changed the text around the videos
Remove invalid comments for old video link and description.
Fixed a comment typo in joins-aggregations.md and added a script directory with all of the Lab scripts.
Made a final pass on these Labs updating some wording and examples.
Copy link
Contributor

@arabellayao arabellayao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Please follow the structure of LiveLabs workshop. Please create a folder called "files" under each lab folder, and put sql files for that lab under the "files" folder. Thanks!

@arabellayao arabellayao merged commit 2cd1e86 into oracle-livelabs:main Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants