-
Notifications
You must be signed in to change notification settings - Fork 152
Final updates to markdown files and added Lab scripts #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New In-Memory 21c Lab
Removed image files and update md files with text to replace images.
Updated manifest.json files for new labs. Only Desktop was up to date. Update README.md for new lab description Fixed setup.md with correct row number for Lineorder table.
Added the proper text for moving to the next lab at the end of each lab's markdown file.
Changed the text around the videos
Remove invalid comments for old video link and description.
Fixed a comment typo in joins-aggregations.md and added a script directory with all of the Lab scripts.
Made a final pass on these Labs updating some wording and examples.
arabellayao
suggested changes
Sep 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Please follow the structure of LiveLabs workshop. Please create a folder called "files" under each lab folder, and put sql files for that lab under the "files" folder. Thanks!
arabellayao
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WMS ID: 11255
General requirements
Checklist - Refer to the QA document for the complete list
Please confirm that the following is completed before submitting your PR