Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WMS ID 11104, Start Polyglot Development with Autonomous Database #339

Merged
merged 17 commits into from
Oct 7, 2024

Conversation

madhusudhanrao-ppm
Copy link
Contributor

@madhusudhanrao-ppm madhusudhanrao-ppm commented Oct 7, 2024

WMS ID 11104

General requirements

  1. Information in the workshop is adequate and updated
  2. Code is correct and working
  3. Links are correct
  4. Make sure you enter the help email link in your manifest.json
  5. Please make sure WMS URLs are updated as needed after your PR is approved

Checklist - Refer to the QA document for the complete list

Please confirm that the following is completed before submitting your PR

Copy link
Contributor

@ramonamagadan18 ramonamagadan18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @madhusudhanrao-ppm! There are some images where the root name is visible. Please hide it:

  • db-application-development/pythondb-development-oracledb/images/copy-connection.png
  • db-application-development/dotnet-development/images/tls-copy.png
  • db-application-development/dotnet-development/images/tns-name.png
  • db-application-development/adb-with-wallet/images/dns-name.png
  • db-application-development/adb-with-wallet/images/tenancy-details.png

blurred compartment name
@madhusudhanrao-ppm
Copy link
Contributor Author

@ramonamagadan18 - compartment names have been blurred, as per your review

ramonamagadan18
ramonamagadan18 previously approved these changes Oct 7, 2024
updated markdowns
Copy link
Contributor

@ramonamagadan18 ramonamagadan18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @madhusudhanrao-ppm . There are some changes:

  • db-application-development/adb-with-wallet/images/Screenshot 2024-10-07 at 7.09.35 PM.png : Please hide tenancy name, username, password and change the name to a more appropriate lowercase name;
  • db-application-development/adb-with-wallet/images/Screenshot 2024-10-07 at 7.10.21 PM.pn: Please hide the root name and change the name to a more appropriate lowercase name;

@madhusudhanrao-ppm
Copy link
Contributor Author

removed screenshots accidentally got it saved in main folder

@ramonamagadan18 ramonamagadan18 merged commit d41a847 into oracle-livelabs:main Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants