Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better options for Java 9 compatibility in project.clj #412

Open
WilliamParker opened this issue Dec 10, 2018 · 1 comment · May be fixed by #413
Open

Better options for Java 9 compatibility in project.clj #412

WilliamParker opened this issue Dec 10, 2018 · 1 comment · May be fixed by #413

Comments

@WilliamParker
Copy link
Collaborator

In #409 we added a profile with arguments necessary to run under Java 9. This profile will only be used during development by those running a Java 9 JVM. I suspect that it is possible to autodetect this in the project setup and adjust accordingly. Alternatively other Clojure(Script) projects may have landed on other standard approach(es) that we might consider.

@eraserhd
Copy link

@WilliamParker It turns out that the module added for development on JDK9 was removed in JDK11, and that it was replaced with a set of normal Maven artifacts. If these artifacts also work on JDK9, then autodetecting is moot, as we can just make the java.xml.bind stuff dev dependencies.

/me goes off to make a patch

eraserhd added a commit to eraserhd/clara-rules that referenced this issue Dec 10, 2018
Closes oracle-samples#412

This should work on all the JDKs.
@eraserhd eraserhd linked a pull request Dec 10, 2018 that will close this issue
eraserhd added a commit to eraserhd/clara-rules that referenced this issue Dec 10, 2018
Closes oracle-samples#412

This should work on all the JDKs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants