Skip to content

Adding RSI example #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 12, 2022
Merged

Adding RSI example #225

merged 4 commits into from
Nov 12, 2022

Conversation

ting-lan-wang
Copy link
Contributor

No description provided.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 10, 2022
@gvenzl gvenzl requested a review from Kuassim November 10, 2022 16:29
Copy link
Contributor

@jeandelavarene jeandelavarene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a copyright to all Java files and Javadoc as well.

Kuassim
Kuassim previously approved these changes Nov 10, 2022
@ting-lan-wang
Copy link
Contributor Author

Working on the copyright and JavaDoc, please do not approve this PR before they're done.

Copy link
Contributor

@gvenzl gvenzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please template the connection strings, they currently have real service names in them.

@ting-lan-wang
Copy link
Contributor Author

ting-lan-wang commented Nov 10, 2022

All the comments have been addressed @gvenzl @jeandelavarene

@gvenzl
Copy link
Contributor

gvenzl commented Nov 11, 2022

Thanks @harayuanwang. Good to go from my side.

@gvenzl gvenzl merged commit 9083b40 into oracle-samples:main Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants