Skip to content

Adopt model file descriptions while creating multi model #1169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025

Conversation

lu-ohai
Copy link
Member

@lu-ohai lu-ohai commented Apr 29, 2025

Adopt model file descriptions while creating multi model

  • Adopt model file description while creating multi model, instead of calling add_artifact as this may cause authentication error to object storage.

Unit test

tests/unitary/with_extras/aqua/test_model.py::TestAquaModel::test_create_model PASSED   [  2%]
tests/unitary/with_extras/aqua/test_model.py::TestAquaModel::test_create_multimodel PASSED [  5%]
tests/unitary/with_extras/aqua/test_model.py::TestAquaModel::test_get_foundation_models[service] PASSED [  8%]
tests/unitary/with_extras/aqua/test_model.py::TestAquaModel::test_get_foundation_models[verified] PASSED [ 11%]
tests/unitary/with_extras/aqua/test_model.py::TestAquaModel::test_get_model_fine_tuned PASSED [ 14%]
tests/unitary/with_extras/aqua/test_model.py::TestAquaModel::test_import_verified_model[True-True-True] PASSED [ 17%]
tests/unitary/with_extras/aqua/test_model.py::TestAquaModel::test_import_verified_model[True-False-True] PASSED [ 20%]
tests/unitary/with_extras/aqua/test_model.py::TestAquaModel::test_import_verified_model[False-True-False] PASSED [ 23%]
tests/unitary/with_extras/aqua/test_model.py::TestAquaModel::test_import_verified_model[False-False-True] PASSED [ 26%]
tests/unitary/with_extras/aqua/test_model.py::TestAquaModel::test_import_any_model_no_containers_specified PASSED [ 29%]
tests/unitary/with_extras/aqua/test_model.py::TestAquaModel::test_import_model_with_project_compartment_override[True] PASSED [ 32%]
tests/unitary/with_extras/aqua/test_model.py::TestAquaModel::test_import_model_with_project_compartment_override[False] PASSED [ 35%]
tests/unitary/with_extras/aqua/test_model.py::TestAquaModel::test_import_model_with_missing_config[True-True] PASSED [ 38%]
tests/unitary/with_extras/aqua/test_model.py::TestAquaModel::test_import_model_with_missing_config[True-False] PASSED [ 41%]
tests/unitary/with_extras/aqua/test_model.py::TestAquaModel::test_import_model_with_missing_config[False-True] PASSED [ 44%]
tests/unitary/with_extras/aqua/test_model.py::TestAquaModel::test_import_model_with_missing_config[False-False] PASSED [ 47%]
tests/unitary/with_extras/aqua/test_model.py::TestAquaModel::test_import_model_with_missing_config[None-False] PASSED [ 50%]
tests/unitary/with_extras/aqua/test_model.py::TestAquaModel::test_import_model_with_missing_config[None-True] PASSED [ 52%]
tests/unitary/with_extras/aqua/test_model.py::TestAquaModel::test_import_any_model_smc_container PASSED [ 55%]
tests/unitary/with_extras/aqua/test_model.py::TestAquaModel::test_import_tei_model_byoc[True] PASSED [ 58%]
tests/unitary/with_extras/aqua/test_model.py::TestAquaModel::test_import_tei_model_byoc[False] PASSED [ 61%]
tests/unitary/with_extras/aqua/test_model.py::TestAquaModel::test_import_model_with_input_tags PASSED [ 64%]
tests/unitary/with_extras/aqua/test_model.py::TestAquaModel::test_import_cli[data0-ads aqua model register --model oracle/oracle-1it --os_path oci://aqua-bkt@aqua-ns/path --download_from_hf True --cleanup_model_cache False --inference_container odsc-vllm-serving] PASSED [ 67%]
tests/unitary/with_extras/aqua/test_model.py::TestAquaModel::test_import_cli[data1-ads aqua model register --model ocid1.datasciencemodel.oc1.iad.<OCID> --os_path oci://aqua-bkt@aqua-ns/path --download_from_hf True --cleanup_model_cache False] PASSED [ 70%]
tests/unitary/with_extras/aqua/test_model.py::TestAquaModel::test_import_cli[data2-ads aqua model register --model oracle/oracle-1it --os_path oci://aqua-bkt@aqua-ns/path --download_from_hf False --cleanup_model_cache False] PASSED [ 73%]
tests/unitary/with_extras/aqua/test_model.py::TestAquaModel::test_import_cli[data3-ads aqua model register --model oracle/oracle-1it --os_path oci://aqua-bkt@aqua-ns/path --download_from_hf True --cleanup_model_cache False --model_file test_model_file] PASSED [ 76%]
tests/unitary/with_extras/aqua/test_model.py::TestAquaModel::test_import_cli[data4-ads aqua model register --model oracle/oracle-1it --os_path oci://aqua-bkt@aqua-ns/path --download_from_hf True --cleanup_model_cache False --inference_container odsc-tei-serving --inference_container_uri <region>.ocir.io/<your_tenancy>/<your_image>] PASSED [ 79%]
tests/unitary/with_extras/aqua/test_model.py::TestAquaModel::test_import_cli[data5-ads aqua model register --model oracle/oracle-1it --os_path oci://aqua-bkt@aqua-ns/path --download_from_hf True --cleanup_model_cache False --inference_container odsc-vllm-serving --freeform_tags {"ftag1": "fvalue1", "ftag2": "fvalue2"} --defined_tags {"dtag1": "dvalue1", "dtag2": "dvalue2"}] PASSED [ 82%]
tests/unitary/with_extras/aqua/test_model.py::TestAquaModel::test_import_cli[data6-ads aqua model register --model oracle/oracle-1it --os_path oci://aqua-bkt@aqua-ns/path --download_from_hf True --cleanup_model_cache True --inference_container odsc-vllm-serving --ignore_model_artifact_check True] PASSED [ 85%]
tests/unitary/with_extras/aqua/test_model.py::TestAquaModel::test_load_license PASSED   [ 88%]
tests/unitary/with_extras/aqua/test_model.py::TestAquaModel::test_list_service_models PASSED [ 91%]
tests/unitary/with_extras/aqua/test_model.py::TestAquaModel::test_list_custom_models PASSED [ 94%]
tests/unitary/with_extras/aqua/test_model.py::TestAquaModel::test_build_search_text_0 PASSED [ 97%]
tests/unitary/with_extras/aqua/test_model.py::TestAquaModel::test_build_search_text_1_This_is_a_description_ PASSED [100%]

===================================== 34 passed in 6.85s ======================================

Notebook

Screenshot 2025-04-29 at 2 12 06 PM Screenshot 2025-04-29 at 2 11 08 PM

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Apr 29, 2025
Copy link

📌 Cov diff with main:

Coverage-96%

📌 Overall coverage:

Coverage-58.62%

Copy link
Member

@VipulMascarenhas VipulMascarenhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@lu-ohai lu-ohai merged commit 845ec6d into main Apr 30, 2025
31 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants