[AQUA][STMD]Updated logic to deploy single ft model #1269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lu-ohai
requested review from
darenr,
mayoor,
mrDzurb,
VipulMascarenhas,
qiuosier and
ahosler
as code owners
oracle-contributor-agreement
bot
added
the
OCA Verified
lu-ohai
changed the title
lu-ohai
changed the title
mrDzurb
reviewed
Sep 17, 2025
ads/aqua/modeldeployment/entities.py
Outdated
| f"Detected base model is fine-tuned model {AQUA_FINE_TUNE_MODEL_VERSION} and switched to stack deployment." | ||
| ) | ||
| segments = aqua_fine_tuned_model.split("#") | ||
| if len(segments) != 2: |
There was a problem hiding this comment.
Can you add some comment describing this logic.
I think we need to make it a bit more flexible. Maybe to create a method in utils somewhere that could extract base model ocid from this tag. What if tomorrow we delete this #model_name from the tag. I thiknk we should still split by #, but then take the first one and check if it is even ocid, if so then we are good.
| "Validation failed: Fine-tuned model ID '%s' is not supported for model deployment.", | ||
| base_model.id, | ||
| ) | ||
| raise ConfigValidationError( |
There was a problem hiding this comment.
I'm not sure if that error makes sense. We might need to give user a better sense what's going on and how to fix the problem.
| ) | ||
|
|
||
| def validate_base_model(self, model_id: str) -> None: | ||
| def validate_base_model(self, model_id: str) -> Union[str, AquaMultiModelRef]: |
There was a problem hiding this comment.
The return sections is missing in the docstring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated logic to deploy ft model as single model.
Unit
Integration