Skip to content

Add blocker for multi deployment #1275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 22, 2025
Merged

Add blocker for multi deployment #1275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4381026
added blocker for updating multi deployment
lu-ohai Sep 22, 2025
ef0096c
Merge branch 'feature/model_group' of https://github.com/oracle/accel…
lu-ohai Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ads/aqua/modeldeployment/deployment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1412,6 +1412,13 @@ def _update_model_group(
The instance of DataScienceModelGroup.
"""
model_group = DataScienceModelGroup.from_id(model_group_id)
if (
model_group.dsc_model_group.model_group_details.type
!= DeploymentType.STACKED
):
raise AquaValueError(
"Invalid 'model_deployment_id'. Only stacked deployment is supported to update."
)
# create a new model group if fine tune weights changed as member models in ds model group is inmutable
if update_model_deployment_details.models:
if len(update_model_deployment_details.models) != 1:
Expand Down
4 changes: 4 additions & 0 deletions tests/unitary/with_extras/aqua/test_deployment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2249,6 +2249,10 @@ def test_update_model_group_deployment(
aqua_model_group = DataScienceModelGroup(
spec=TestDataset.aqua_deployment_stack_model
)
model_group_details = MagicMock(type="STACKED")
aqua_model_group.dsc_model_group = MagicMock(
model_group_details=model_group_details
)
aqua_model_group.set_spec(
aqua_model_group.CONST_BASE_MODEL_ID,
"ocid1.datasciencemodel.oc1.iad.<OCID>",
Expand Down