Bump coherence testing to latest CE releases.

.github/workflows/node.js.yml

@@ -29,7 +29,7 @@ jobs:
       fail-fast: false
       matrix:
         node-version: [18.15.x, 19.x]
-        coherence-version: [22.06.2, 23.03]
+        coherence-version: [22.06.5, 23.03.1]
 
     steps:
     - uses: actions/checkout@v3

.github/workflows/release.yml

@@ -37,8 +37,8 @@ jobs:
       - run: echo "/tmp/grpc/bin" >> $GITHUB_PATH
       - run: npm install
       # run unit tests
-      - run: COHERENCE_VERSION=22.06.2 npm run test-cycle
-      - run: COHERENCE_VERSION=23.03 npm run test-cycle
+      - run: COHERENCE_VERSION=22.06.5 npm run test-cycle
+      - run: COHERENCE_VERSION=23.03.1 npm run test-cycle
       - run: npm install --no-save typedoc
       # generate dist which runs other tasks
       - run: npm run dist

bin/docker-utils.sh

@@ -7,7 +7,7 @@
 
 set -e
 
-declare VERSION=${COHERENCE_VERSION:=22.06.2}
+declare VERSION=${COHERENCE_VERSION:=22.06.5}
 
 function coh_up() {
   echo "Starting test containers ..."
@@ -17,6 +17,7 @@ function coh_up() {
   while [ ${SECONDS} -le 60 ]; do
     READY=$(curl -o /dev/null -s -w "%{http_code}" "http://127.0.0.1:6676/ready") || true
     if [ "${READY}" -eq "200" ]; then
+      sleep 5
       echo "Coherence is ready!"
       return
     fi

test/serialization-tests.js

@@ -119,11 +119,6 @@ describe('Serialization Unit/Integration Test Suite', () => {
     })
 
     describe("Serialization Integration Tests", () => {
-        if (test.COHERENCE_VERSION.startsWith("22.06")) {
-            it("are skipped if running against 22.06", () => {} )
-            return
-        }
-
         const session = new Session()
         const cache = session.getCache("test-ser")
 

test/util.js

@@ -7,19 +7,11 @@
 const Decimal = require("decimal.js");
 const assert = require('assert').strict
 
-const COHERENCE_VERSION = "COHERENCE_VERSION" in process.env ? process.env.COHERENCE_VERSION : "22.06"
-
 module.exports = {
-  COHERENCE_VERSION,
-
   checkNumericResult: function (result, expected) {
-    let numberResultExpected = COHERENCE_VERSION.startsWith("22.06")
-
-    if (numberResultExpected && typeof(result) === 'number') {
-      assert.equal(result, expected)
-    } else if (!numberResultExpected && result instanceof Decimal) {
+    if (result instanceof Decimal) {
       assert.deepStrictEqual(result, new Decimal(expected))
-    } else if (!numberResultExpected && typeof(result) === 'bigint') {
+    } else if (typeof(result) === 'bigint') {
         assert.deepStrictEqual(result, BigInt(expected))
     } else {
       assert(false, "Unexpected result type [" + typeof(result) + "]")