Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add space before the header value in getAllResponseHeaders #67

Closed
wants to merge 1 commit into from

Conversation

ewfian
Copy link

@ewfian ewfian commented Oct 1, 2020

This pull request add a single space before header value (after colon). then the polyfilled getAllResponseHeaders() will return the same format value with native

  1. The origin http header
    image

  2. Parsed response header
    image

  3. The return value of polyfilled getAllResponseHeaders()
    The space lost here
    image

  4. The FIRST CHAR LOST.
    Some 3rd libraries like azure-sdk-for-js makes http request by using XMLHttpRequest and parses header by itself just like following code
    https://github.com/Azure/azure-sdk-for-js/blob/744e51acb755db2c565c71a8856d8d13e6ec345b/sdk/core/core-https/src/xhrHttpsClient.ts#L129
    If the return value from the polyfilled function XMLHttpRequest.getAllResponseHeaders() is not keeps the exact same format (Date: Thu, 01 Oct 2020 05:18:27 GMT\r\n) as the original value, some thing will broken.
    image

image

@ewfian
Copy link
Author

ewfian commented Oct 1, 2020

Sorry for contributing rules. I will close this pull request and create an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant