Remove volume expose #1560
Merged
Remove volume expose #1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gerald Venzl <gerald.venzl@oracle.com>
Signed-off-by: Gerald Venzl <gerald.venzl@oracle.com>
Signed-off-by: Gerald Venzl <gerald.venzl@oracle.com>
Signed-off-by: Gerald Venzl <gerald.venzl@oracle.com>
Signed-off-by: Gerald Venzl <gerald.venzl@oracle.com>
Signed-off-by: Gerald Venzl <gerald.venzl@oracle.com>
Signed-off-by: Gerald Venzl <gerald.venzl@oracle.com>
Signed-off-by: Gerald Venzl <gerald.venzl@oracle.com>
Signed-off-by: Gerald Venzl <gerald.venzl@oracle.com>
Djelibeybi
requested changes
Mar 26, 2020
Signed-off-by: Gerald Venzl <gerald.venzl@oracle.com>
Signed-off-by: Gerald Venzl <gerald.venzl@oracle.com>
|
Addresses #640 |
Djelibeybi
requested changes
Mar 26, 2020
OracleDatabase/SingleInstance/dockerfiles/11.2.0.2/Dockerfile.xe
Outdated
Show resolved
Hide resolved
OracleDatabase/SingleInstance/dockerfiles/12.1.0.2/Dockerfile.ee
Outdated
Show resolved
Hide resolved
OracleDatabase/SingleInstance/dockerfiles/12.1.0.2/Dockerfile.se2
Outdated
Show resolved
Hide resolved
Signed-off-by: Gerald Venzl <gerald.venzl@oracle.com>
Signed-off-by: Gerald Venzl <gerald.venzl@oracle.com>
Signed-off-by: Gerald Venzl <gerald.venzl@oracle.com>
Signed-off-by: Gerald Venzl <gerald.venzl@oracle.com>
Djelibeybi
previously approved these changes
Mar 27, 2020
|
Fine with me. You can merge once @mriccell reviews too. |
mriccell
requested changes
Mar 30, 2020
Signed-off-by: Gerald Venzl <gerald.venzl@oracle.com>
Djelibeybi
previously approved these changes
Apr 1, 2020
Signed-off-by: Gerald Venzl <gerald.venzl@oracle.com>
mriccell
approved these changes
Apr 1, 2020
|
@gvenzl could you please give me a hint on why you use LABELs for volumes and ports instead of VOLUME or EXPOSE? I haven't seen this before. |
|
@chahn the labels are to provide additional detail in a way that doesn't impose restrictions on how the image is actually used. They're there for decoration purposes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VOLUMEfrom Database imagesEXPOSEfrom Database imagesLABELfor volume, expose and other informationLABELguidelines@Djelibeybi, please review everything ;)
@mriccell, please review Contributing.md and an example regarding the label structure.