Skip to content

Commit

Permalink
Remove check for info func println in debuginfotest
Browse files Browse the repository at this point in the history
After the merge of ee638aa
println(String) is being inlined in Java 17 and thus it can no longer be
listed with `info func println`. Note that we already have a similar
check that takes in account inlining and uses methods defined in the
Hello test, so the removal of this check should be OK.

(cherry picked from commit 1d548b0)
  • Loading branch information
zakkak authored and marwan-hallaoui committed Dec 21, 2021
1 parent 308e018 commit 26887c6
Showing 1 changed file with 2 additions and 12 deletions.
14 changes: 2 additions & 12 deletions substratevm/mx.substratevm/testhello.py
Original file line number Diff line number Diff line change
Expand Up @@ -287,17 +287,6 @@ def test():
checker = Checker("info func greet", rexp)
checker.check(exec_string)

# look up PrintStream.println methods
# expect "All functions matching regular expression "java.io.PrintStream.println":"
# expect ""
# expect "File java.base/java/io/PrintStream.java:"
# expect " void java.io.PrintStream::println(java.lang.Object *);"
# expect " void java.io.PrintStream::println(java.lang.String *);"
exec_string = execute("info func java.io.PrintStream::println")
rexp = r"%svoid java.io.PrintStream::println\(java\.lang\.String \*\)"%maybe_spaces_pattern
checker = Checker("info func java.io.PrintStream::println", rexp)
checker.check(exec_string)

# step into method call
execute("step")

Expand Down Expand Up @@ -522,7 +511,8 @@ def test():
checker = Checker('ptype hello.Hello', rexp)
checker.check(exec_string, skip_fails=False)

# list methods matching regural expression "nlined", inline methods are not listed
# list methods matching regural expression "nline", inline methods are not listed because they lack a definition
# (this is true for C/C++ as well)
exec_string = execute("info func nline")
rexp = [r"All functions matching regular expression \"nline\":",
r"File hello/Hello\.java:",
Expand Down

0 comments on commit 26887c6

Please sign in to comment.