-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Provide java.lang.Terminator.setup() via --install-exit-handlers #2393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/JavaMainWrapper.java
Outdated
Show resolved
Hide resolved
substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/JavaMainWrapper.java
Outdated
Show resolved
Hide resolved
substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/SubstrateOptions.java
Outdated
Show resolved
Hide resolved
@pejovica reminded me that there is |
Arrg calling the code from |
You need to reset |
Tested if this also works on Windows
LGTM |
substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/JavaMainWrapper.java
Outdated
Show resolved
Hide resolved
substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/JavaMainWrapper.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nicely done!
This PR provides a fix for #1592
Testing with
shows an image size increase of 48Kb when native-image --install-exit-handlers is used (from 6,802,048 bytes to 6,850,976 bytes)