-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adaptive GC policy and other improvements. #3589
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d6e603a
to
eca580b
Compare
eca580b
to
0615f42
Compare
25b4e29
to
575ebed
Compare
06f523a
to
a49118a
Compare
…en and survivors.
…ile its referent is not.
…fix initial eden size.
…n incremental GC.
…generation; use young generation size for basic policies, too.
…ing incorrectness.
a1a8112
to
db1b88c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the core of this PR is a (partial) port of HotSpot's ParallelGC
PSAdaptiveSizePolicy
, which tries to meet a throughput goal while maintaining a low footprint by adjusting the space sizes and the tenuring threshold based on statistical information that it keeps.The other changes in this PR are improvements and fixes to make our serial GC behave more like ParallelGC (without the parallel part). Most prominently, this means using survivor spaces during full GCs and for pinned objects and tenuring survivor objects during a collection once the young generation is full. The old GC policies and their behavior are retained.
In its current state, peak throughput can be significantly higher than with the previous GC policy, but typically at the price of a higher peak resident set size, as benchmarked with microservice workloads.