Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace jdk8 github gates with jdk17 ones #3981

Merged
merged 2 commits into from
Nov 6, 2021

Conversation

zakkak
Copy link
Collaborator

@zakkak zakkak commented Nov 2, 2021

Complementary to #3967

@zakkak
Copy link
Collaborator Author

zakkak commented Nov 2, 2021

@dougxc according to the runs on my fork the only failing gate (and I expect it to fail in this PR's runs as well) is

${MX_PATH}/mx --primary-suite-path vm --J @"-Xmx2g" --java-home=${JAVA_HOME} gate --strict-mode --tags build,sulong

It fails with:

([1/288] Building C object CMakeFiles/interop_interop003.c.dir_toolchain-plain.dir/interop/interop003.c.o
FAILED: CMakeFiles/interop_interop003.c.dir_toolchain-plain.dir/interop/interop003.c.o 
/home/runner/work/mandrel/mandrel/sulong/mxbuild/linux-amd64/SULONG_BOOTSTRAP_TOOLCHAIN/bin/graalvm-native-clang -Dinterop_interop003_c_dir_toolchain_plain_EXPORTS  -g -Wno-unused-function -I/home/runner/work/mandrel/mandrel/sulong/mxbuild/jdk17/SULONG_LEGACY/include -I/home/runner/work/mandrel/mandrel/sdk/mxbuild/linux-amd64/GRAALVM_AD9B45A953_JAVA17/graalvm-ad9b45a953-java17-22.0.0-dev/jre/languages/llvm/include -fPIC -MD -MT CMakeFiles/interop_interop003.c.dir_toolchain-plain.dir/interop/interop003.c.o -MF CMakeFiles/interop_interop003.c.dir_toolchain-plain.dir/interop/interop003.c.o.d -o CMakeFiles/interop_interop003.c.dir_toolchain-plain.dir/interop/interop003.c.o -c /home/runner/work/mandrel/mandrel/sulong/tests/com.oracle.truffle.llvm.tests.interop.native/interop/interop003.c
/home/runner/work/mandrel/mandrel/sulong/tests/com.oracle.truffle.llvm.tests.interop.native/interop/interop003.c:30:10: fatal error: 'graalvm/llvm/polyglot.h' file not found
#include <graalvm/llvm/polyglot.h>
         ^~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Since I have no experience at all in building or testing sulong could you please have someone have a look at it?

@dougxc
Copy link
Member

dougxc commented Nov 2, 2021

@rschatz could you please help with this sulong build issue.

@rschatz
Copy link
Member

rschatz commented Nov 3, 2021

Huh... -I/home/runner/work/graal/graal/sdk/mxbuild/linux-amd64/GRAALVM_AD9B45A953_JAVA17/graalvm-ad9b45a953-java17-22.0.0-dev/jre/languages/llvm/include...

That should be languages/llvm/include, not jre/languages/llvm/include. I wonder why that doesn't fail in our internal gates. I'll investigate.

@rschatz
Copy link
Member

rschatz commented Nov 4, 2021

That particular job is still at JDK8 internally, I overlooked it because it's in the vm suite, not in the sulong suite ;)

@pejovica is already working on a fix.

@pejovica
Copy link
Member

pejovica commented Nov 5, 2021

@zakkak I'll integrate this PR together with the fix for the sulong gate.

@zakkak
Copy link
Collaborator Author

zakkak commented Nov 5, 2021

@zakkak I'll integrate this PR together with the fix for the sulong gate.

Ack, thanks for the heads up and for taking care of it.

@graalvmbot graalvmbot merged commit 4550c69 into oracle:master Nov 6, 2021
@zakkak zakkak deleted the gh-actions-jdk8-to-jdk17-on-main branch November 8, 2021 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants