[GR-39967] Skip constant folding of reflection methods with side effects. #5156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
graalvmbot
force-pushed
the
cs/GR-39967-reflection-plugins-class-init
branch
3 times, most recently
from
d8a49ed to
2f3a147
Compare
graalvmbot
force-pushed
the
cs/GR-39967-reflection-plugins-class-init
branch
from
2f3a147 to
758223b
Compare
zakkak
reviewed
Oct 18, 2023
Comment on lines
+203
to
+208
| /** | ||
| * For some methods check if folding an invocation using reflection, i.e., by executing the | ||
| * target method and capturing the result, has undesired side effects, such as triggering | ||
| * initialization of classes that should be initialized at run time. This is based on knowledge | ||
| * about the reflection API methods implementation. | ||
| */ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.