[GR-44099] Optimize card table scanning. #5963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
petermz
reviewed
Feb 14, 2023
...m.core.genscavenge/src/com/oracle/svm/core/genscavenge/remset/AlignedChunkRememberedSet.java
Outdated
Show resolved
Hide resolved
| cardPos = cardPos.subtract(wordSize()); | ||
| while (cardPos.aboveOrEqual(cardTableStart) && ((UnsignedWord) cardPos.readWord(0)).equal(CardTable.CLEAN_WORD)) { | ||
| cardPos = cardPos.subtract(wordSize()); | ||
| } |
There was a problem hiding this comment.
A do-while loop would be incorrect because there is no guarantee that the whole word is clean.
graalvmbot
force-pushed
the
chaeubl/GR-44099-v2
branch
from
140d4e7 to
bc2b7dd
Compare
petermz
approved these changes
Feb 16, 2023
graalvmbot
force-pushed
the
chaeubl/GR-44099-v2
branch
from
bc2b7dd to
48d2f66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.