[GR-46732] Revive UnsafeFieldAccessorFactory for Native Image #6879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
graalvmbot
deleted the
je/svm-revive-unsafe-field-access-factory-GR-46732
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JDK 19 ships with JEP 416, which reimplements core reflection with method handles. However, the old Unsafe-based implementation was still available and used by Native Image. In JDK 22, the old core reflection implementation was removed. Since the method handle based implementation is designed with Just-in-Time compilation in mind, and would have bad performance in an Ahead-of-Time scenario, we decided to keep old implementation.
This revives the Unsafe-based core reflection implementation as available until JDK 22 build +2.