[GR-56601] Initial support for jcmd. #9963
Conversation
oracle-contributor-agreement
bot
added
the
OCA Verified
There was a problem hiding this comment.
Thank you for doing this PR @christianhaeubl! This looks really good to me.
|
|
||
| @Override | ||
| public List<Class<? extends Feature>> getRequiredFeatures() { | ||
| return List.of(SigQuitFeature.class, AttachApiFeature.class); |
There was a problem hiding this comment.
Should the DCmdFeature also be included in this list?
There was a problem hiding this comment.
Good point, it is indeed cleaner if DCmdFeature is included here as well.
| return String.join(System.lineSeparator(), lines); | ||
| } | ||
|
|
||
| private static String[] getHelp(Target_jdk_jfr_internal_dcmd_AbstractDCmd cmd) { |
There was a problem hiding this comment.
The JFR.start DCMD from the JDK shows extended JFR configuration options (that aren't supported) as part of it's help text. It's not a big problem since you return a descriptive error message Warning! The .jfc option/setting 'xyz' doesn't exist or is not supported. The other option would be to print custom help text, copy-pasting the parts we support in Native Image. However, maybe that's not really worth the duplication and maintenance of keeping it up to date.
There was a problem hiding this comment.
Right, there is a bit too much output. Most extended configuration options are already hidden due to the substitution of Target_jdk_jfr_internal_dcmd_DCmdStart.jfcOptions(). I don't think that it is worth to duplicate the help text, so I think we will just live with the extra output for now.
graalvmbot
force-pushed
the
chaeubl/GR-56601
branch
from
a3dde59
to
d397bf3
Compare
graalvmbot
force-pushed
the
chaeubl/GR-56601
branch
from
d397bf3
to
10528ff
Compare
graalvmbot
force-pushed
the
chaeubl/GR-56601
branch
from
10528ff
to
25ae2cd
Compare
graalvmbot
force-pushed
the
chaeubl/GR-56601
branch
from
2545793
to
ea1ce56
Compare
This PR is based on #9232 (there is not much code left from the original PR though) and contains the following changes:
JCmdFeature).jcmdsupport builds on top of the attach API (seePosixAttachApiSupportand the files incom.oracle.svm.core.attachandcom.oracle.svm.core.posix.attach)SIGQUIT/SIGBREAKand domain sockets for communicationcom.oracle.svm.core.jvmstat.SystemCounters).jcmdcan access the performance counters to detect which process are running.SIGQUIT/SIGBREAK. This PR extends the existing feature and renames it fromDumpRuntimeCompilationOnSignalFeaturetoSigQuitFeature.com.oracle.svm.core.dcmd.*) that can be triggered viajcmd-XX:StartFlightRecordingandjcmd <pid> JFR.startuse the same code and have the same behavior.JVMSupport.makeFilenameand the JFR startup.jcmd <pid> GC.heap_dump dump.hprof.