[GR-60775] Removing an obsolete problematic hack in ExecuteNativeProp…

…ertyHandlerNode. PullRequest: js/3373
oracle · Jan 2, 2025 · 0206e9f · 0206e9f
2 parents 5f7ef77 + 432bc37
commit 0206e9f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/...trufflenode/src/com/oracle/truffle/trufflenode/node/ExecuteNativePropertyHandlerNode.java b/...trufflenode/src/com/oracle/truffle/trufflenode/node/ExecuteNativePropertyHandlerNode.java
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2018, 2023, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2018, 2025, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * The Universal Permissive License (UPL), Version 1.0
@@ -281,10 +281,6 @@ private Object executeGetOwnPropertyDescriptor(ObjectTemplate template, Object h
             }
             if (desc == null) {
                 desc = JSObject.getOwnProperty((JSDynamicObject) arguments[2], arguments[3]);
-                if (desc == null && indexedHandler != null) {
-                    // handles a suspicious part of indexedinterceptors-test in nan package
-                    desc = executeGetOwnPropertyDescriptorHelper(template, holder, arguments, false);
-                }
             }
         }
         return (desc == null) ? Undefined.instance : JSRuntime.fromPropertyDescriptor(desc, context);

diff --git a/graal-nodejs/test/graal/unit/vm.js b/graal-nodejs/test/graal/unit/vm.js
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2018, 2025, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * The Universal Permissive License (UPL), Version 1.0
@@ -151,4 +151,7 @@ describe('vm', function () {
         assert(!globalPropertySymbols.includes(Symbol.unscopables), globalPropertySymbols);
         assert.strictEqual(43, vm.runInContext('globalThis[Symbol.unscopables]', context));
     });
+    it('should handle globalThis.hasOwnProperty(symbol)', function () {
+        assert.ok(!vm.runInNewContext("globalThis.hasOwnProperty(Symbol())"));
+    });
 });