GraalJSScriptEngine: NPE when setting empty engine bindings #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes oracle#839 Cherry picked from: 69c6c87: GraalJSScriptEngine: NPE when setting empty engine bindings 16d63fa: Correction of the year in the copyright header.
oracle-contributor-agreement
bot
added
the
OCA Verified
iamstolis
approved these changes
Oct 3, 2024
|
Is there anything blocking this backport to 23.1 ? |
In fact, these changes have been backported internally already. They should be part of 23.1.6 (that should be released early next year). I am just afraid that the corresponding team and their automated backporting process ignores public backport PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #839
Cherry picked from:
69c6c87: GraalJSScriptEngine: NPE when setting empty engine bindings
16d63fa: Correction of the year in the copyright header.
According to our discussion at the GraalVM Community Workshop I'd like to revitalize the
release/graal-vm/23.1branch and downport this trivial fix which already landed in the upstream master branch.This fix is required to pass the Java 21 JCK tests if the GraalJS module is bundled (i.e. "jlinked") with the JDK as a system module.