-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scan new versions for existing libraries #552
Conversation
7c25881
to
2a338c9
Compare
f61dc30
to
0841c01
Compare
tests/tck-build-logic/src/main/groovy/org.graalvm.internal.tck-harness.gradle
Outdated
Show resolved
Hide resolved
tests/tck-build-logic/src/main/groovy/org.graalvm.internal.tck-harness.gradle
Outdated
Show resolved
Hide resolved
tests/tck-build-logic/src/main/groovy/org.graalvm.internal.tck-harness.gradle
Outdated
Show resolved
Hide resolved
tests/tck-build-logic/src/main/groovy/org.graalvm.internal.tck-harness.gradle
Outdated
Show resolved
Hide resolved
tests/tck-build-logic/src/main/groovy/org.graalvm.internal.tck-harness.gradle
Outdated
Show resolved
Hide resolved
This PR requires a detailed explanation (in the form of docs) on how the new version is computed. |
tests/tck-build-logic/src/main/groovy/org.graalvm.internal.tck-harness.gradle
Outdated
Show resolved
Hide resolved
tests/tck-build-logic/src/main/groovy/org/graalvm/internal/tck/harness/TckExtension.java
Outdated
Show resolved
Hide resolved
tests/tck-build-logic/src/main/groovy/org/graalvm/internal/tck/harness/TckExtension.java
Outdated
Show resolved
Hide resolved
tests/tck-build-logic/src/main/java/org/graalvm/internal/tck/TestedVersionUpdaterTask.java
Outdated
Show resolved
Hide resolved
Maybe we should start some kind of infrastructure changelog? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionally-wise, sounds good to me. The implementation however needs a couple reworks to be Gradle idiomatic (and not break up-to-date checking/configuration).
tests/tck-build-logic/src/main/groovy/org.graalvm.internal.tck-harness.gradle
Outdated
Show resolved
Hide resolved
tests/tck-build-logic/src/main/groovy/org.graalvm.internal.tck-harness.gradle
Outdated
Show resolved
Hide resolved
tests/tck-build-logic/src/main/java/org/graalvm/internal/tck/TestedVersionUpdaterTask.java
Show resolved
Hide resolved
tests/tck-build-logic/src/main/java/org/graalvm/internal/tck/TestedVersionUpdaterTask.java
Outdated
Show resolved
Hide resolved
tests/tck-build-logic/src/main/java/org/graalvm/internal/tck/TestedVersionUpdaterTask.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there, almost there!
What does this PR do?
This PR introduces a new GitHub workflow that scans for newer versions of libraries that currently exist in the repo.
When there is a newer version available, we are trying to run existing tests with existing metadata to verify if tests can pass.
tested-versions
list in the correspondingindex.json
file. Accumulated results will be provided through an automatically created PR.NOTE: we must allow github actions to create PRs automatically.