This repository was archived by the owner on Nov 25, 2020. It is now read-only.
[WIP] Add shared memory support. #32
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Never mind: Posix shm isn't very portable (since Darwin has a shm_get syscall while it's a glibc wrapper to open a file on Moved the creation of shm client into |
monktastic
force-pushed
the
aprasad-shm
branch
from
f9e8019 to
263d068
Compare
monktastic
force-pushed
the
aprasad-shm
branch
from
263d068 to
520d820
Compare
…sync. Add a speed test (that also demonstrates shared memory usage).
monktastic
force-pushed
the
aprasad-shm
branch
from
520d820 to
1eca5d9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this breaks the MultiRemoteRaw API. It also adds a dep on
github.com/gen2brain/shm. For this reason alone I might switch to posix shm, which doesn't require any deps.I don't necessarily need to check in client-test (though it serves as an example of how to construct a shm client). I might move that code to a helper function in client.go.