Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config change support refactoring #1417

Merged
merged 34 commits into from
Mar 9, 2020

Conversation

tomas-langer
Copy link
Member

Fixes #579
Fixes #1183
Fixes #578

@tomas-langer tomas-langer added api-change 2.x Issues for 2.x version branch labels Feb 20, 2020
@tomas-langer tomas-langer self-assigned this Feb 20, 2020
@tomas-langer
Copy link
Member Author

Follow up: #1420

@tomas-langer tomas-langer marked this pull request as ready for review February 20, 2020 18:39
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
spericas
spericas previously approved these changes Feb 27, 2020
Copy link
Member

@spericas spericas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A difficult to review PR due to the number of changes. Looks good overall but it's hard to comment on some parts. The changes to the docs are nice.

danielkec
danielkec previously approved these changes Mar 5, 2020
@tomas-langer tomas-langer requested a review from danielkec March 5, 2020 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Issues for 2.x version branch api-change
Projects
None yet
4 participants