Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If-else statement code folding is misleading without showing else #249

Closed
slowhog opened this issue Aug 28, 2024 · 0 comments · Fixed by #304
Closed

If-else statement code folding is misleading without showing else #249

slowhog opened this issue Aug 28, 2024 · 0 comments · Fixed by #304
Labels
bug Something isn't working
Milestone
JVSC 23.0.1

Comments

@slowhog
Copy link
Member

slowhog commented Aug 28, 2024

If-else statement folding on if should either stop at else or at the end of else.

The following screenshots demonstrate the issue,

Screenshot 2024-08-28 at 10 44 29 AM

After collapse the if-else statement, what was shown is actually the else block, this is confusing.

Screenshot 2024-08-28 at 10 44 59 AM
@sid-srini sid-srini added the enhancement New feature or request label Aug 29, 2024
@Achal1607 Achal1607 added bug Something isn't working and removed enhancement New feature or request labels Sep 10, 2024
@sid-srini sid-srini mentioned this issue Sep 13, 2024
Merged
sid-srini added a commit to sid-srini/javavscode that referenced this issue Sep 13, 2024
@sid-srini
[JVSC-249] Fix code folding in VS Code due to line-only folding limit…
6760dc1 
…ation

Added the draft NB PR 7750 diff which allows supporting LSP clients
which have line-only folding support.
- This is the case of VS Code as referenced in microsoft/vscode#50840.

Closes oracle#249

Signed-off-by: Siddharth Srinivasan <siddharth.srinivasan@oracle.com>
@sid-srini sid-srini mentioned this issue Sep 13, 2024
Closed
sid-srini added a commit to sid-srini/javavscode that referenced this issue Sep 13, 2024
@sid-srini
[JVSC-249] Fix code folding in VS Code due to line-only folding limit…
a03fc5a 
…ation

Added the backport of the draft NB PR 7750 diff which allows supporting LSP clients
which have line-only folding support.
- This is the case of VS Code as referenced in microsoft/vscode#50840.

Closes oracle#249

Signed-off-by: Siddharth Srinivasan <siddharth.srinivasan@oracle.com>
sid-srini added a commit to sid-srini/javavscode that referenced this issue Sep 17, 2024
@sid-srini
[JVSC-249] Fix code folding in VS Code due to line-only folding limit…
426cc29 
…ation

Added the backport of the in-review NB PR 7750 diff which allows supporting LSP clients
which have line-only folding support.
- This is the case of VS Code as referenced in microsoft/vscode#50840.

Closes oracle#249

Signed-off-by: Siddharth Srinivasan <siddharth.srinivasan@oracle.com>
sid-srini added a commit to sid-srini/javavscode that referenced this issue Oct 26, 2024
@sid-srini
[JVSC-249] Fix code folding in VS Code due to line-only folding limit…
68c7ae0 
…ation

Added the backport of the Netbeans PR apache/netbeans#7750 patch which allows supporting LSP clients
which have line-only folding support.
- This is the case of VS Code as referenced in microsoft/vscode#50840.

Closes oracle#249

Signed-off-by: Siddharth Srinivasan <siddharth.srinivasan@oracle.com>
@sid-srini sid-srini mentioned this issue Oct 26, 2024
Merged
@Achal1607 Achal1607 added the In-Progress For the issues being worked on label Oct 28, 2024
@Achal1607 Achal1607 added this to the JVSC 23.0.1 milestone Oct 28, 2024
@Achal1607 Achal1607 removed the In-Progress For the issues being worked on label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
JVSC 23.0.1
Development

Successfully merging a pull request may close this issue.

[JVSC-249] Fix code folding in VS Code due to line-only folding limitation sid-srini/javavscode
3 participants
@slowhog @Achal1607 @sid-srini