Skip to content

fix(pypi): update get_maintainers_of_package to avoid request blocking #1097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2025
Merged

fix(pypi): update get_maintainers_of_package to avoid request blocking #1097

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37a0a51
fix(pypi): update get_maintainers_of_package to avoid request blocking
AmineRaouane Jun 3, 2025
630cb8c
chore(pypi): add comment to clarify handling of trailing slash in URLs
AmineRaouane Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/macaron/slsa_analyzer/package_registry/pypi_registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,8 @@ def get_package_page(self, package_name: str) -> str | None:
str | None
The package main page.
"""
url = os.path.join(self.registry_url, "project", package_name)
# Important: trailing '/' avoids JS-based redirect; ensures Macaron can access the page directly
url = urllib.parse.urljoin(self.registry_url, f"project/{package_name}/")
response = send_get_http_raw(url)
if response:
html_snippets = response.content.decode("utf-8")
Expand Down Expand Up @@ -360,7 +361,8 @@ def get_maintainer_profile_page(self, username: str) -> str | None:
str | None
The profile page.
"""
url = os.path.join(self.registry_url, "user", username)
# Important: trailing '/' avoids JS-based redirect; ensures Macaron can access the page directly
url = urllib.parse.urljoin(self.registry_url, f"user/{username}/")
response = send_get_http_raw(url, headers=None)
if response:
html_snippets = response.content.decode("utf-8")
Expand Down
Loading