generated from oracle/template-repo
-
Notifications
You must be signed in to change notification settings - Fork 30
feat(heuristics): add Fake Email analyzer to validate maintainer email domain #1106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c6f35f7 to
8d29103
Compare
f945882 to
a7103e4
Compare
benmss
reviewed
Jul 9, 2025
benmss
reviewed
Jul 9, 2025
benmss
reviewed
Jul 9, 2025
src/macaron/malware_analyzer/pypi_heuristics/metadata/fake_email.py
Outdated
Show resolved
Hide resolved
759ab97 to
d99495c
Compare
benmss
reviewed
Jul 14, 2025
benmss
reviewed
Jul 14, 2025
d99495c to
a8d373b
Compare
benmss
previously approved these changes
Jul 15, 2025
behnazh-w
requested changes
Jul 18, 2025
src/macaron/malware_analyzer/pypi_heuristics/metadata/fake_email.py
Outdated
Show resolved
Hide resolved
art1f1c3R
reviewed
Jul 21, 2025
art1f1c3R
reviewed
Jul 21, 2025
src/macaron/malware_analyzer/pypi_heuristics/metadata/fake_email.py
Outdated
Show resolved
Hide resolved
art1f1c3R
reviewed
Jul 21, 2025
95aa0cc to
468d67e
Compare
art1f1c3R
reviewed
Jul 22, 2025
468d67e to
80db475
Compare
behnazh-w
previously approved these changes
Jul 31, 2025
art1f1c3R
previously approved these changes
Jul 31, 2025
80db475 to
036af0a
Compare
…acle#1122) Signed-off-by: Amine <amine.raouane@enim.ac.ma>
…l domains Signed-off-by: Amine <amine.raouane@enim.ac.ma>
Signed-off-by: Amine <amine.raouane@enim.ac.ma>
Signed-off-by: Amine <amine.raouane@enim.ac.ma>
…mail domain validation Signed-off-by: Amine <amine.raouane@enim.ac.ma>
Signed-off-by: Amine <amine.raouane@enim.ac.ma>
e0e8067 to
4dfae43
Compare
Signed-off-by: Behnaz Hassanshahi <behnaz.hassanshahi@oracle.com>
behnazh-w
approved these changes
Aug 5, 2025
benmss
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new heuristic analyzer called
FakeEmailAnalyzer. It verifies the validity of maintainer email addresses listed in a PyPI package by checking both the format and the existence of MX records for their domains. This helps detect packages with fake or throwaway emails, which are often indicative of malicious intent.Description of changes
FakeEmailAnalyzerthat:detect_malicious_metadata_check.pyto include and invoke this new analyzer.Related issues
None
Checklist
verifiedlabel should appear next to all of your commits on GitHub.