Skip to content

fix: improve run_macaron.sh bash and docker version compatibility #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2024
Merged

fix: improve run_macaron.sh bash and docker version compatibility #717

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion scripts/release_scripts/run_macaron.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,6 +524,11 @@ fi
USER_UID="$(id -u)"
USER_GID="$(id -g)"

# Disable unset variable errors from here on to support older bash versions
# where "${array[*]}" and "${array[@]}" expressions throw errors (in set -u mode)
# when the array is empty despite otherwise having the correct behaviour.
set +u

if [[ -z "${entrypoint[*]}" ]];
then
entrypoint=("macaron")
Expand Down Expand Up @@ -564,8 +569,22 @@ fi
# Reference: https://docs.podman.io/en/v4.4/markdown/options/userns.container.html.
export PODMAN_USERNS=keep-id

# Pull image based on DOCKER_PULL setting, emulating behaviour of
# docker run --pull ${DOCKER_PULL} ...
# to support older versions of docker that do not support the "--pull" argument.
if [[ "${DOCKER_PULL}" == "always" ]]; then
docker image pull "${IMAGE}:${MACARON_IMAGE_TAG}"
elif [[ "${DOCKER_PULL}" == "missing" ]]; then
docker image inspect "${IMAGE}:${MACARON_IMAGE_TAG}" &> /dev/null || docker image pull "${IMAGE}:${MACARON_IMAGE_TAG}"
else
# "${DOCKER_PULL}" == "never"
if ! docker image inspect "${IMAGE}:${MACARON_IMAGE_TAG}" &> /dev/null; then
echo "Docker image '${IMAGE}:${MACARON_IMAGE_TAG}' not found locally and DOCKER_PULL == never, aborting"
exit 1
fi
fi

docker run \
--pull "${DOCKER_PULL}" \
--network=host \
--rm -i "${tty[@]}" \
-e "USER_UID=${USER_UID}" \
Expand Down