chore: improve commit finder and input handling #741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… improve input handling Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
oracle-contributor-agreement
bot
added
the
OCA Verified
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
tromai
reviewed
May 21, 2024
nicallen
approved these changes
May 21, 2024
tromai
approved these changes
May 22, 2024
Contributor
tromai
left a comment
tromai
left a comment
There was a problem hiding this comment.
Thanks for the change. LGTM
behnazh-w
approved these changes
May 24, 2024
art1f1c3R
pushed a commit
that referenced
this pull request
Nov 29, 2024
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
benmss
deleted the
benmss/allow-all-lhs-zero-padded-digits-in-commit-finder
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the commit finder so that it can handle cases where numeric version parts have preceding zeroes. E.g. Version
2024.2.2-> Tag2024.02.02. The trailing zero evaluation (for the version as a whole) has also been updated to accept "long" zeros, e.g.1.00,1.000.In addition, PURLs with an invalid type as defined in the spec are rejected before analysis begins.
Partially relates to discussion in #706