Skip to content

Conversation

benmss
Copy link
Member

@benmss benmss commented Jun 6, 2024

This PR converts the integration test expectation files used for output and dependency comparison into policy files that can be verified using Macaron's verify-policy command. It also modifies the integration test script to use the new policy files.

…ests

Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jun 6, 2024
@benmss benmss marked this pull request as ready for review June 7, 2024 05:39
@benmss benmss requested review from behnazh-w and tromai as code owners June 7, 2024 05:39
@behnazh-w behnazh-w requested review from nicallen and nathanwn June 9, 2024 23:15
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
benmss added 3 commits June 10, 2024 16:33
… policies and revert usage in script

Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
Copy link
Member

@nathanwn nathanwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

@behnazh-w
Copy link
Member

We are still comparing the JSON outputs in integration_tests_docker.sh. Can you please adjust these tests as well? I think we should be able to remove the JSON outputs from the repository in this PR.

…cker integration tests

Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
@behnazh-w behnazh-w self-requested a review June 13, 2024 02:01
art1f1c3R pushed a commit that referenced this pull request Nov 29, 2024
…ests (#760)

Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
@benmss benmss deleted the benmss/use-verify-policy-integration-test branch April 8, 2025 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants