generated from oracle/template-repo
-
Notifications
You must be signed in to change notification settings - Fork 29
test: add new integration test utility #764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e522f3e
to
ee4f891
Compare
Signed-off-by: Nathan Nguyen <nathan.nguyen@oracle.com>
Signed-off-by: Nathan Nguyen <nathan.nguyen@oracle.com>
Signed-off-by: Nathan Nguyen <nathan.nguyen@oracle.com>
Signed-off-by: Nathan Nguyen <nathan.nguyen@oracle.com>
Signed-off-by: Nathan Nguyen <nathan.nguyen@oracle.com>
Signed-off-by: Nathan Nguyen <nathan.nguyen@oracle.com>
Signed-off-by: Nathan Nguyen <nathan.nguyen@oracle.com>
Signed-off-by: Nathan Nguyen <nathan.nguyen@oracle.com>
Signed-off-by: Nathan Nguyen <nathan.nguyen@oracle.com>
Signed-off-by: Nathan Nguyen <nathan.nguyen@oracle.com>
Signed-off-by: Nathan Nguyen <nathan.nguyen@oracle.com>
Signed-off-by: Nathan Nguyen <nathan.nguyen@oracle.com>
Signed-off-by: Nathan Nguyen <nathan.nguyen@oracle.com>
Signed-off-by: Nathan Nguyen <nathan.nguyen@oracle.com>
Signed-off-by: Nathan Nguyen <nathan.nguyen@oracle.com>
Signed-off-by: Nathan Nguyen <nathan.nguyen@oracle.com>
87c0311
to
e8715d8
Compare
…kefile Signed-off-by: Nathan Nguyen <nathan.nguyen@oracle.com>
Rebased to resolve conflicts with |
tromai
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the change.
Thanks a lot 🙂 |
behnazh-w
approved these changes
Jun 24, 2024
This was referenced Jun 24, 2024
This was referenced Sep 2, 2024
art1f1c3R
pushed a commit
that referenced
this pull request
Nov 29, 2024
Signed-off-by: Nathan Nguyen <nathan.nguyen@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new integration test utility script that:
macaron
Python package, but also any wrapper script of Macaron (including but not limited to therun_macaron.sh
script).run_macaron.sh
wrapper script, or disabling certain test cases when some services are unreachable.This pull request also converts a large number of test cases from the old integration test setup to this new setup with the utility. Some conversions may conflict with some changes made in #748, but hopefully not be too hard to resolve; otherwise, we can selectively drop certain commits from this PR before merging and proceed with the conversion later.
Changes
The utility script and test data
The utility script and test data are under the
tests/integration
directory. Detailed instructions for the utility script can be found in theREADME.md
file under the same directory.Most test cases specified in YAML config are converted from the old
integration_test.sh
andintegration_test_docker.sh
script. For each converted test case, I made it a separate commit for easy review. Please refer to the list of commits when you review the conversion.Changes to Makefile
Instead of completely replacing
scripts/dev_script/{integration_tests,integration_test_docker}.sh
, the new utility script is now called within both scripts, since this PR only converts parts of these scripts and not fully.Since the
{integration_tests,integration_test_docker}.sh
are not fully replaced, no Makefile change is required.Changes to GitHub Actions Workflows
The integration test utility script requires two dependencies already available in the development virtual environment:
ruamel.yaml
for YAML parsing andcfgv
for human-readable YAML validation errors.The script also requires Python 3.11, although compatibility with other Python versions has not been tested. Another pending pull request, #748, is also adding Python to the
.github/workflows/_build_docker.yml
workflow file, and so our change is similar here.Changes to Documentation
Besides the
./tests/integration/README.md
file, reference was made to the new integration test utility in theWriting a New Check
section on theMacaron Developer's Guide
website page.Commits
The first commit in this PR includes the integration test utility, GitHub Actions workflow changes, and documentation changes. Each later PR converts a test case from the previous setup to this new setup.