generated from oracle/template-repo
-
Notifications
You must be signed in to change notification settings - Fork 28
feat: add a script to check VSA #858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e22889d
to
3335a6f
Compare
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
3335a6f
to
e9b4e7a
Compare
tromai
reviewed
Sep 12, 2024
docs/source/pages/tutorials/use_verification_summary_attestation.rst
Outdated
Show resolved
Hide resolved
tromai
reviewed
Sep 12, 2024
docs/source/pages/tutorials/use_verification_summary_attestation.rst
Outdated
Show resolved
Hide resolved
tromai
reviewed
Sep 12, 2024
tromai
reviewed
Sep 12, 2024
tromai
reviewed
Sep 12, 2024
docs/source/pages/tutorials/use_verification_summary_attestation.rst
Outdated
Show resolved
Hide resolved
tromai
reviewed
Sep 12, 2024
tromai
reviewed
Sep 12, 2024
tromai
requested changes
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. I have added some comments/ change requests.
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
tromai
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
tromai
reviewed
Sep 13, 2024
docs/source/pages/tutorials/use_verification_summary_attestation.rst
Outdated
Show resolved
Hide resolved
tromai
reviewed
Sep 13, 2024
docs/source/pages/tutorials/use_verification_summary_attestation.rst
Outdated
Show resolved
Hide resolved
tromai
reviewed
Sep 13, 2024
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
tromai
approved these changes
Sep 15, 2024
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
tromai
approved these changes
Sep 15, 2024
art1f1c3R
pushed a commit
that referenced
this pull request
Nov 29, 2024
This PR adds the check_vsa.sh script, which takes an artifact, VSA, and the package URL as the artifact identifier and reports whether the verification result has been successful. This PR also adds a tutorial for the VSAs published for the Graal Development Kit (GDK) artifacts. The integration test checks micronaut-core@4.5.3 with a manually generated VSA as well as micronaut-core@4.6.5 whose VSA is published on Oracle Maven. Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
check_vsa.sh
script, which takes an artifact, VSA, and the package URL as the artifact identifier and reports whether the verification result has been successful.This PR also adds a tutorial for the VSAs published for the Graal Development Kit (GDK) artifacts. The Oracle Maven URLs are not accessible yet and will be working once GDK is released.
The integration test checks
micronaut-core@4.5.3
with a manually generated VSA as well asmicronaut-core@4.6.5
whose VSA is published on Oracle Maven.