chore: fix Makefile goal gnu-sed to handle brew, port, and GNU sed on macOS gracefully

[jenstroeger]

Fix to PR #853 (tagging @mabdollahpour-ol)

The Makefile goal assumed Brew only, so I added support for Ports and a check for gsed to avoid installing it twice. Also note that at least Ports aliases gsed as sed such that

macaron/scripts/dev_scripts/copyright-checker.sh

Lines 55 to 59 in edfe06e

	SED="sed"
	# Use gnu-sed (gsed) on mac.
	if [[ "$(uname)" == "Darwin" ]]; then
	SED="gsed"
	fi

becomes irrelevant. I don’t know how Brew manages overriding macOS CLI tools with GNU tools.

Furthermore, I cleaned up indentation to be consistent with most (not all!) of the Makefile: every line of a rule indents by a single tab, then two spaces within scripts. That way it is easier to tell the difference between tab-indent (four or eight, depending on the editor) and space-indent (always two), and it makes managing block-indents easier & consistent.

Lastly, I think this line

macaron/Makefile

Line 167 in edfe06e

echo "Unable to install Souffle. Please install it manually." && exit 0; \

should contain an exit 1 to communicate the failure correctly to the running shell.

[mabdollahpour-ol]

Thanks!

I don’t know how Brew manages overriding macOS CLI tools with GNU tools.

It doesn't anymore. It used to have --with-default-names that would override the apple stuff but now it lets the users to do the aliasing/overriding themselves. brew installs the gnu stuff with a g prefix. That's why there is gsed in the script.

The Makefile goal assumed Brew only

Not just this goal. We only use brew to install souffle as well. We should probably be consistent in using these tools.

[jenstroeger]

Not just this goal. We only use brew to install souffle as well. We should probably be consistent in using these tools.

The souffle goal doesn’t have a Ports check because there’s not Portsfile available for Souffle.

[behnazh-w]

Lastly, I think this line

macaron/Makefile

Line 167 in edfe06e

echo "Unable to install Souffle. Please install it manually." && exit 0; \

@jenstroeger Thanks. That's actually intentional. We just want to let the user know that they should install Souffle manually, but the setup should not be considered as failed.