fix: report known malware even when not labeled #956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
behnazh-w
force-pushed
the
behnazh/improve-known-mal-check
branch
from
6f9d7f4 to
0089979
Compare
tromai
reviewed
Jan 5, 2025
benmss
reviewed
Jan 6, 2025
benmss
reviewed
Jan 6, 2025
art1f1c3R
reviewed
Jan 6, 2025
behnazh-w
force-pushed
the
behnazh/improve-known-mal-check
branch
from
0089979 to
20155c3
Compare
art1f1c3R
approved these changes
Jan 6, 2025
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
behnazh-w
force-pushed
the
behnazh/improve-known-mal-check
branch
from
20155c3 to
60d5ec2
Compare
benmss
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the malicious packages are not clearly labeled in the OSV knowledge base. This PR improves the known malware detection in
detect_malicious_metadata_check. It also adds a new abstraction for the deps.dev service to improve code reusability.