This repository was archived by the owner on May 28, 2021. It is now read-only.
Changes build to publish docker images to all OCIR regions #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonlord
force-pushed
the
push-to-ocir
branch
4 times, most recently
from
83a0a93 to
98f5d20
Compare
|
@simonlord Needs a rebase |
owainlewis
reviewed
May 21, 2018
Makefile
Outdated
| @@ -24,7 +24,7 @@ endif | |||
|
|
|||
| ROOT_DIR := $(shell dirname $(abspath $(lastword $(MAKEFILE_LIST)))) | |||
| PKG := github.com/oracle/mysql-operator | |||
| REGISTRY := wcr.io/oracle | |||
| REGISTRY := iad.ocir.io/oracle | |||
There was a problem hiding this comment.
Might want to change this to iad.ocir.io/spinnaker to make sure local make pushes go to our tenancy and not oracle which we'll preserve for tagged releases only.
owainlewis
reviewed
May 21, 2018
Makefile
Outdated
| @@ -17,14 +17,16 @@ USE_GLOBAL_NAMESPACE ?= false | |||
| ifdef WERCKER | |||
| # Insert swear words about mysql group replication and hostname length. Arghh.. | |||
| VERSION := ${WERCKER_GIT_COMMIT} | |||
| TENANT := "oracle" | |||
owainlewis
reviewed
May 21, 2018
Makefile
Outdated
| else | ||
| NEW_NAMESPACE ?= e2e-${USER} | ||
| VERSION := ${USER}-$(shell date +%Y%m%d%H%M%S) | ||
| TENANT := "spinnaker" |
Also worth noting i've set all the repo's across the regions to public. Also i've added OCIRUSERNAME and OCIRPASSWORD env vars to wercker env vars config.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also worth noting i've set all the repo's across the regions to public. Also i've added OCIRUSERNAME and OCIRPASSWORD env vars to wercker env vars config.