Skip to content

Added index.d.ts to expose types for typescript. #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

Bigous
Copy link
Contributor

@Bigous Bigous commented Feb 1, 2016

Resolving issue #169.

@Bigous
Copy link
Contributor Author

Bigous commented Jul 27, 2016

Hi @cjbj, I think we could cancel this pull request until we decide if we are going to keep DefinelyTyped or use typescript as a helper at JavaScript layer, so we can have this automagicaly generated (and so the api documentation).
What do you think?
[]'s

@Bigous
Copy link
Contributor Author

Bigous commented Jul 27, 2016

Just to attach things - we discussed it, ending in lets wait at #333.
From that point to now (7 months), Typescript evolved a lot. I really think that it would be very nice to have the Javascript part rewritten in TypeScript generating the Javascript and adding definitions and documentation on it.

@cjbj
Copy link
Member

cjbj commented Jul 28, 2016

@Bigous thanks for the updated pull at DefinitelyTyped/DefinitelyTyped#10323 I think that is the right home for the definition file at the moment. You may recall I had some reservations about merging to node-oracledb and there are a bunch of other things (temporary lobs, longs etc) that need attention. If you close this, we can alweays reopen it later.

@Bigous
Copy link
Contributor Author

Bigous commented Jul 28, 2016

Sure, lets keep it separated for now and reopen later or create another one !!!

@Bigous Bigous closed this Jul 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants