Easily discover groups in authorization plugins #1527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tulinkry
changed the title
tulinkry
force-pushed
the
auth-plugins-discovery
branch
from
b089edb to
fd73308
Compare
vladak
reviewed
Apr 21, 2017
| */ | ||
| public Set<Project> getAllProjects() { | ||
| Set<Project> projectsTmp = new TreeSet<>(); | ||
| for (Project p : getRepositories()) { |
There was a problem hiding this comment.
the getRepositories() name is confusing to me as it clashes with the Repository object.
There was a problem hiding this comment.
I agree however I couldn't think of a better name for the projet-repository type (listed on the main page under the search form). Do you have better idea?
There was a problem hiding this comment.
If I understand it correctly, the repositories contains projects with at least one Repository (according to populateGroups() so maybe it shall be named projectsWithRepo or such ?
vladak
reviewed
Apr 25, 2017
| } | ||
|
|
||
| private void discoverGroup(String group, HttpServletRequest request, Set<String> descendants) { | ||
| private void discoverGroup(String group, HttpServletRequest request) { |
- adding a javadoc
tulinkry
force-pushed
the
auth-plugins-discovery
branch
from
fd73308 to
8adb7a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expects the #1525 to be merged as it already implements the new interface.
This change moves the responsibility of a group discovery
to the opengrok code and the plugin can just call the new methods if it wants to add all subgroups/repositories/.. to the allowed set.