Use jetty-jspc. Fix opensearch.jsp exposed error. #2569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use mergeFragment=false with jetty-jspc so pre-compiled JSP classes are not included in the WAR. Also: - use skipTests not maven.test.skip w.r.t. the short-circuiting the setting up of testdata.
idodeclare
force-pushed
the
feature/affirm_jspc
branch
from
15c406f to
2f226e6
Compare
Pull Request Test Coverage Report for Build 3765
💛 - Coveralls |
Member
|
Nice ! I always wanted to have this capability. |
Contributor
|
Isn't there an issue about some compile jsp things? |
Contributor
Author
|
@tulinkry, none that I’m aware of. I was longing for the compilation check that NetBeans did when you built the web project, and jetty-jspc seems the modern way to do it with maven. |
Contributor
|
I think I meant this one #1322 but that's sort of a different issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Please consider for integration this patch to add a jetty-jspc step to affirm that the JSP files compile without error. One JSP,
opensearch.jsp, had an error and is fixed.mergeFragment=falseso pre-compiled JSP classes will not be included in the WAR.skipTestsnotmaven.test.skipw.r.t. the short-circuiting the setting up of testdata.Thank you.